Skip to Content

New J2Commerce 6.6.5 is out. Here is everything in the release.

See What’s New
Account
Enter the email address on your account.
Forgot your username?
Enter your password.
Forgot your password?

Or continue with

Closed Public Category: Technical Support / Bugs Ticket #690

HTML syntax in J2STORE_WIHSLIST_BROWSE_WIHSLIST_VIEW breaks wishlist plugin

This is a public ticket

Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.

Conversation

Peter Reill

When I use plain text for the language key J2STORE_WIHSLIST_BROWSE_WIHSLIST_VIEW, the following link code is generated:

<a href="https://www.j2commerce.com/javascript:void(0);" class="product-wishlist-link text-decoration-none" data-wishlist-link="/component/j2store/? Itemid=159 “ data-wishlist-action-done=”Item added“ data-wishlist-wishlist-view=”Show wish list“ data-wishlist-action-timeout=”1000“ data-wishlist-product-id=‘4’ data-wishlist-variant-id=”4" data-wishlist-id= “313” data-enable_redirect=‘0’ data-wishlist_link_type=“text” onclick="addToWishlist(this,‘/shop/zahlenbausteine-aus-holz.html’)">
<span class="wishlist-text"><span class="wishlist-icon fas fa-solid fa-heart"></span> Add to wish list</span>
</a>

 

However, if it contains HTML syntax, it breaks the entire link at the point data-wishlist-wishlist-view

<a href="https://www.j2commerce.com/javascript:void(0);" class="product-wishlist-link text-decoration-none" data-wishlist-link="/component/j2store/? Itemid=159 “ data-wishlist-action-done=”Item added“ data-wishlist-wishlist-view=”&lt;span class=" wishlist-icon="“ fas="" fa-solid=”“ fa-heart”=‘’> Show wish list"
data-wishlist-action-timeout=“1000”
data-wishlist-product-id=“4”
data-wishlist-variant-id=“4”
data-wishlist-id=“313”
data-enable_redirect=“0”
data-wishlist_link_type=“text”
onClick="addToWishlist(this,‘/shop/zahlenbausteine-aus-holz.html’)"
&gt;
<span class="wishlist-text"><span class="wishlist-icon fas fa-solid fa-heart"></span> Add to wish list</span>
</a>

 

Isn't it sufficient to use a universal placeholder for data-wishlist-wishlist-view?

Olivier Buisard Staff

Hi Peter, 

that means the key is not escaped, which needs to be fixed internally.

Thanks for reporting this.

Olivier.